Anatoly Lubarsky

Logo
MSSQL, .NET, Design. Life and Music

ASP.NET 2.0: MasterPage HtmlHead Renders Messy HTML

This bug in MasterPage's HtmlHead control rendering is rather annoying to say the least. If head element is specified as runat="server" at design time it seems that ASP.NET renders all previously design-time defined tags as one literal control, which means - it renders all tags as one long string eating all line-breaks. Suppose the following head element in MasterPage markup like so:


< !DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 
Transitional//EN" "DTD/xhtml1-transitional.dtd">
< html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en">
< head runat="server">
< title>< /title>
< meta http-equiv="content-type" content="text/html; charset=utf-8" />
< meta name="keywords" content="mykwords" />
< link href="/mycss.css" type="text/css" rel="stylesheet" />
< /head>

Now I go and set the title in the content page like so:


this.Header.Title = "My Title";

Expecting to get just the same markup for my head element with title string just inside title tag. I don't expect head element to be totally reformatted !


Instead, what I get is:


  • All design-time tags are rendered as one long string without line-breaks.
  • Title tag is rendered without line-break before and after.
  • Title tag has 2 additional line-breaks before and after its innerHtml.
  • Title tag has additional tab character after the line-break before its innerHtml starts.

LOL. Somebody has to take care of this...


Related Posts:

Wednesday, January 10, 2007 4:25 AM

Comments

# re: ASP.NET 2.0: MasterPage HtmlHead Renders Messy HTML
This stupid behavior can be overriden using control adapters. I've written three classes for <head>, <meta> and <link> controls so that they render nice html.

But there's a problem with CSS rules added to HtmlHead through StyleSheet property. I don't use it but think that is should be implemented for sake of consistency. The class that renders it's html code is marked internal and i can't find a way make it render to specific HtmlWriter.

The code is quite short (<100 lines) and i can copy it here if you need it.

1/29/2007 3:43 PM by Bazile

# re: ASP.NET 2.0: MasterPage HtmlHead Renders Messy HTML
Bazile: thanks for the tip.

You can post the code if you want. I promise to make a post of it later and give you full credit.

1/29/2007 9:22 PM by Anatoly Lubarsky

# re: ASP.NET 2.0: MasterPage HtmlHead Renders Messy HTML
1) Control adapters source. It can be compiled into your assembly or placed into App_Code folder.
---------------------------------------------------------------------
using System;
using System.Collections;
using System.Web.UI;
using System.Web.UI.HtmlControls;

namespace YourNamespace
{
public class HtmlHeadAdapter : System.Web.UI.Adapters.ControlAdapter
{
protected override void Render(HtmlTextWriter writer)
{
writer.WriteLine("<head>");
HtmlHead headTag = (HtmlHead)this.Control;
ControlCollection controls = headTag.Controls;
for (int i=0; i<controls.Count; i++)
{
Control c = controls[i];
headTag.Controls[i].RenderControl(writer);
}
// Стили - yet to be implemented
/*if (this.Page.Request.Browser["requiresXhtmlCssSuppression"] != "true")
{
headTag.StyleSheet.Render();
}*/
// Заголовок
writer.Write("<title>");
writer.Write(Page.Title);
writer.WriteLine("</title>");
writer.Write("</head>");
}
}

public class HtmlLinkAdapter : System.Web.UI.Adapters.ControlAdapter
{
protected override void Render(HtmlTextWriter writer)
{
HtmlLink linkTag = (HtmlLink)this.Control;
writer.Write("<link");
AttributeCollection attributes = linkTag.Attributes;
IEnumerator keys = linkTag.Attributes.Keys.GetEnumerator();
while (keys.MoveNext())
{
string key = (string)keys.Current;
writer.Write(" ");
writer.Write(key);
writer.Write("=\"");
writer.Write(attributes[key]);
writer.Write("\"");
}
writer.WriteLine(">");
}
}

public class HtmlMetaAdapter : System.Web.UI.Adapters.ControlAdapter
{
protected override void Render(HtmlTextWriter writer)
{
HtmlMeta metaTag = (HtmlMeta)this.Control;
writer.Write("<meta http-equiv=\"");
writer.Write(metaTag.HttpEquiv);
writer.Write("\" content=\"");
writer.Write(metaTag.Content);
writer.WriteLine("\">");
}
}
}
---------------------------------------------------------------------

2) To register control adapters create folder App_Browsers in the root of your web application. Then create a file named Default.browser with this content:

<browsers>
<browser refID="Default">
<controlAdapters>
<adapter
controlType="System.Web.UI.HtmlControls.HtmlHead"
adapterType="YourNamespace.HtmlHeadAdapter"
/>
<adapter
controlType="System.Web.UI.HtmlControls.HtmlLink"
adapterType="YourNamespace.HtmlLinkAdapter"
/>
<adapter
controlType="System.Web.UI.HtmlControls.HtmlMeta"
adapterType="YourNamespace.HtmlMetaAdapter"
/>
</controlAdapters>
</browser>
</browsers>

1/30/2007 10:20 AM by Bazile

# ASP.NET 2.0: Override MasterPage HtmlHead Rendering with ControlAdapters

1/31/2007 1:28 AM by Anatoly Lubarsky

# ASP.NET 2.0: HtmlHead Rendering ControlAdapters implementation

1/31/2007 2:51 AM by Anatoly Lubarsky

If your feedback doesn't appear right away, please be patient as it may take a few minutes to publish.

Post a Comment

Protected by CAPTCHAEnter the code you see
Name (*)  
E-mail (*)  
Url
Remember

Comment (*)  

Search

Google
Entire Web
Facebook
YouTube
MSDN
Just this site

Login

RSS
Add to Google Add to My Yahoo! Subscribe with Bloglines
Fosimo on CNET Download.com!
Microsoft Certified Solution Developer
Microsoft Certified Database Administrator

Article Categories

.Net Framework
ASP.NET Tips
C# Win32 API
HTML, CSS, Web
Javascript Tips
MSSQL Tips
System
System.Net
WebServices

Archives

(03) May, 2008
(06) April, 2008
(03) March, 2008
(02) February, 2008
(04) January, 2008
(03) December, 2007
(05) November, 2007
(06) October, 2007
(07) September, 2007
(13) August, 2007
(11) July, 2007
(14) June, 2007
(16) May, 2007
(14) April, 2007
(10) March, 2007
(17) February, 2007
(21) January, 2007
(17) December, 2006
(14) November, 2006
(13) October, 2006
(13) September, 2006
(14) August, 2006
(12) July, 2006
(11) June, 2006
(12) May, 2006
(22) April, 2006
(36) March, 2006
(14) February, 2006
(14) January, 2006
(20) December, 2005
(17) November, 2005
(17) October, 2005
(17) September, 2005
(14) August, 2005
(18) July, 2005
(12) June, 2005
(17) May, 2005
(13) April, 2005
(22) March, 2005
(12) February, 2005
(14) January, 2005
(19) December, 2004
(15) November, 2004
(13) October, 2004
(16) September, 2004
(12) August, 2004
(29) July, 2004
(25) June, 2004
(33) May, 2004
(26) April, 2004
(18) March, 2004
(11) February, 2004
(07) January, 2004
(03) December, 2003
(02) November, 2003

Post Categories

.Net and C#
Antispam
Architecture
ASP.NET
Blogging
del.icio.us
Facebook
Fosimo
Fun
Google
Javascript
Misc.
MSSQL
Music
Performance
Roller
Tools
Visual Studio
Web 2.0
WebServices
Yahoo

About Me

linkedin Profile
Recs
Recs Books
Who am I

My Sites

onecone
x2line
x2line blogs

Web 2.0

del.icio.us - add me
Delicer - download